Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Add function to get module lib #3871

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Dec 12, 2020

Description

This adds a function to find module library.

Co-authored-by: @Palakis

Motivation and Context

In order to easily find the library file needed to load the browser panels on Linux, these functions were added. This should work on Mac and Windows as well.

Used code made by @Palakis, as they were trying to make Linux browser panels work as well.

How Has This Been Tested?

Tested with obsproject/obs-browser#254

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Dec 12, 2020
@notr1ch
Copy link
Member

notr1ch commented Dec 14, 2020

I don't think this should be modifying obs-module.h. That header is included by plugins - the MODULE_EXPORT define is for exporting symbols by plugins, eg obs_module_load().

@cg2121
Copy link
Contributor Author

cg2121 commented Dec 19, 2020

I've moved them now to obs.h

@WizardCM
Copy link
Member

I have verified this works well on Ubuntu.

cg2121 added a commit to cg2121/obs-browser that referenced this pull request Jan 17, 2021
@jp9000
Copy link
Member

jp9000 commented Jan 25, 2021

Are you aware of the obs_get_module() function?

This adds a function find module library.

Co-authored-by: Stéphane Lepin <[email protected]>
@cg2121 cg2121 force-pushed the module-functions branch 2 times, most recently from 93a3c4e to cc92733 Compare January 26, 2021 05:22
@cg2121 cg2121 changed the title libobs: Add module functions libobs: Add function to get module lib Jan 26, 2021
@cg2121
Copy link
Contributor Author

cg2121 commented Jan 26, 2021

@jp9000 didn't notice that function. I've updated it now to only add the module library function.

@jp9000
Copy link
Member

jp9000 commented Jan 26, 2021

Sorry about that. Figured you might've missed it.

@jp9000 jp9000 merged commit 99d10c2 into obsproject:master Jan 26, 2021
cg2121 added a commit to cg2121/obs-browser that referenced this pull request Jan 26, 2021
WizardCM pushed a commit to cg2121/obs-browser that referenced this pull request Jan 26, 2021
@cg2121 cg2121 deleted the module-functions branch November 8, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants