Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix qt-helpers.{c,h}pp not being removed from legacy.cmake #10967

Merged
merged 1 commit into from
Jul 11, 2024
Merged

UI: Fix qt-helpers.{c,h}pp not being removed from legacy.cmake #10967

merged 1 commit into from
Jul 11, 2024

Conversation

palana
Copy link
Contributor

@palana palana commented Jul 11, 2024

Description

#10957 removed a few files from CMakeLists.txt, but did not remove them from legacy.cmake (see #10957 (comment))

Motivation and Context

Legacy CMake should still work

How Has This Been Tested?

Untested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@palana palana mentioned this pull request Jul 11, 2024
Merged
6 tasks
@RytoEX RytoEX self-assigned this Jul 11, 2024
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Jul 11, 2024
@RytoEX RytoEX added this to the OBS Studio 30.2 milestone Jul 11, 2024
@Chiitoo
Copy link
Contributor

Chiitoo commented Jul 11, 2024

Works for me.

Thank ye!

@RytoEX RytoEX merged commit 3a88427 into obsproject:master Jul 11, 2024
15 checks passed
@palana palana deleted the ruwen/multitrack-video-without-qfuture branch July 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

Assignees

@RytoEX RytoEX

Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Milestone
OBS Studio 30.2
Development

Successfully merging this pull request may close these issues.
3 participants
@palana @Chiitoo @RytoEX