Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apple Notes bugs #146

Merged
merged 10 commits into from
Oct 24, 2023
Merged

Fix Apple Notes bugs #146

merged 10 commits into from
Oct 24, 2023

Conversation

mirnovov
Copy link
Contributor

@mirnovov mirnovov commented Oct 20, 2023

Closes #143 by implementing support for relative attachment paths.
Closes #144 by handling folder errors and escaping folder names (I naively didn't think folders could fail as they've pretty straightforward).
Closes #148 by switching to the root attachments folder when the account-based one is nonexistent (which should be extremely rare). If the cause of Apple Notes using a different folder is found, I'll change it so it detects that.
Per multiple requests on social media, adds option to include text that Apple Notes detects in drawings.

Also has a few other enhancements and fixes from more testing I've done:

  • Fix issues with trash folder with multiple accounts
  • Make importer more robust by not relying on SQLite columns that are likely to change in future macOS versions.
  • Fixes issues with SQL statements that have empty arrays, by replacing another dependency with a directly included version. I have raised an issue in the original repo: Queries with empty arrays are broken WebReflection/sqlite-tag-spawned#7 by updating the static-params dependency with a fix I contributed to it.

@kepano kepano requested review from tgrosinger and lishid October 23, 2023 15:46
src/formats/apple-notes.ts Show resolved Hide resolved
src/formats/apple-notes.ts Show resolved Hide resolved
src/formats/apple-notes.ts Outdated Show resolved Hide resolved
src/formats/apple-notes.ts Show resolved Hide resolved
src/formats/apple-notes/sqlite/static-params.js Outdated Show resolved Hide resolved
@lishid lishid merged commit fcfad91 into obsidianmd:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants