Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove KAFKA_PROPERTIES_FILE; allow user to use mounted file #502

Merged
merged 8 commits into from
Apr 7, 2023
+27 −6
Merged

Don't remove KAFKA_PROPERTIES_FILE; allow user to use mounted file #502

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
98f39b3
touch, don't rm, KAFKA_PROPERTIES_FILE
brsolomon-deloitte Apr 6, 2023
69ac5bf
Update kafdrop.sh
brsolomon-deloitte Apr 6, 2023
9f62b6b
Update kafdrop.sh
brsolomon-deloitte Apr 7, 2023
e1c819a
Update kafdrop.sh
brsolomon-deloitte Apr 7, 2023
4e6ffe0
Update README.md
brsolomon-deloitte Apr 7, 2023
4a9a6f0
Update README.md
brsolomon-deloitte Apr 7, 2023
5ffb777
Use elif->touch pattern for all _FILE vars
brsolomon-deloitte Apr 7, 2023
bdd0d2b
Update README.md
brsolomon-deloitte Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,25 @@ docker run -d --rm -p 9000:9000 \
-e KAFKA_KEYSTORE="$(cat kafka.keystore.jks | base64)" \ # optional
obsidiandynamics/kafdrop
```

Rather than passing `KAFKA_PROPERTIES` as a base64-encoded string, you can also place a pre-populated `KAFKA_PROPERTIES_FILE` into the container:

```sh
cat << EOF > kafka.properties
security.protocol=SASL_SSL
sasl.mechanism=SCRAM-SHA-512
sasl.jaas.config=org.apache.kafka.common.security.scram.ScramLoginModule required username="foo" password="bar"
EOF

docker run -d --rm -p 9000:9000 \
-v $(pwd)/kafka.properties:/tmp/kafka.properties:ro \
-e KAFKA_BROKERCONNECT=<host:port,host:port> \
-e KAFKA_PROPERTIES_FILE=/tmp/kafka.properties \
-e KAFKA_TRUSTSTORE="$(cat kafka.truststore.jks | base64)" \ # optional
-e KAFKA_KEYSTORE="$(cat kafka.keystore.jks | base64)" \ # optional
obsidiandynamics/kafdrop
brsolomon-deloitte marked this conversation as resolved.
Show resolved Hide resolved
```

#### Environment Variables
##### Basic configuration
|Name |Description
Expand Down
12 changes: 6 additions & 6 deletions src/main/docker/kafdrop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,24 @@ KAFKA_PROPERTIES_FILE=${KAFKA_PROPERTIES_FILE:-kafka.properties}
if [ "$KAFKA_PROPERTIES" != "" ]; then
echo Writing Kafka properties into $KAFKA_PROPERTIES_FILE
echo "$KAFKA_PROPERTIES" | base64 --decode --ignore-garbage > $KAFKA_PROPERTIES_FILE
else
rm $KAFKA_PROPERTIES_FILE |& > /dev/null | true
elif [ ! -f $KAFKA_PROPERTIES_FILE ]; then
touch $KAFKA_PROPERTIES_FILE
fi

KAFKA_TRUSTSTORE_FILE=${KAFKA_TRUSTSTORE_FILE:-kafka.truststore.jks}
if [ "$KAFKA_TRUSTSTORE" != "" ]; then
echo Writing Kafka truststore into $KAFKA_TRUSTSTORE_FILE
echo "$KAFKA_TRUSTSTORE" | base64 --decode --ignore-garbage > $KAFKA_TRUSTSTORE_FILE
else
rm $KAFKA_TRUSTSTORE_FILE |& > /dev/null | true
elif [ ! -f $KAFKA_TRUSTSTORE_FILE ]; then
touch $KAFKA_TRUSTSTORE_FILE
fi

KAFKA_KEYSTORE_FILE=${KAFKA_KEYSTORE_FILE:-kafka.keystore.jks}
if [ "$KAFKA_KEYSTORE" != "" ]; then
echo Writing Kafka keystore into $KAFKA_KEYSTORE_FILE
echo "$KAFKA_KEYSTORE" | base64 --decode --ignore-garbage > $KAFKA_KEYSTORE_FILE
else
rm $KAFKA_KEYSTORE_FILE |& > /dev/null | true
elif [ ! -f $KAFKA_KEYSTORE_FILE ]; then
touch $KAFKA_KEYSTORE_FILE
fi

ARGS="--add-opens=java.base/sun.nio.ch=ALL-UNNAMED -Xss256K \
Expand Down