fix: document S3 backup behavior #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
approved these changes
Aug 22, 2023
hutchic
approved these changes
Aug 22, 2023
|
Whoops forgot the pre-commit generate hook, it's a pain to not be able to edit these via the GH UI. Authors of lots of modules will generally automate this as it discourages small contributions: https://github.com/cloudposse At some point I'd be inclined to implement a workflow that uses App credentials to do this and push back to the PR while re-triggering Actions. Definitely post extraction from |
bendrucker
force-pushed
the
s3-backup-var-desc
branch
from
d0ddd75
to
5a783d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes a bit of user-facing guidance from a code comment to the variable description where it's directly accessible to module callers. Also explains what the default means.