Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename code_version to sam_release_version #166

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jta
Copy link
Contributor

@jta jta commented Jun 7, 2024

The original variable name does not adequately capture there are other assets beyond code which are of interest to our terraform module. In particular, we want to be able to get the recommended metric filter based on the pinned version.

@jta jta requested a review from a team as a code owner June 7, 2024 17:46
@jta jta force-pushed the joao/rename-code-version branch from cffabed to 1ba3fc9 Compare June 7, 2024 17:53
The original variable name does not adequately capture there are other
assets beyond code which are of interest to our terraform module. In
particular, we want to be able to get the recommended metric filter
based on the pinned version.
@jta jta force-pushed the joao/rename-code-version branch from 1ba3fc9 to d3a7f09 Compare June 7, 2024 17:55
@jta jta merged commit 42a682e into main Jun 7, 2024
43 checks passed
@jta jta deleted the joao/rename-code-version branch June 7, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant