fix: Move k8s.cluster.name to resource_attributes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-enricogiorio
force-pushed
the
enrico/resourceAttributesLogs
branch
2 times, most recently
from
f5b70d4
to
2ea105d
Compare
obs-gh-enricogiorio
force-pushed
the
enrico/resourceAttributesLogs
branch
3 times, most recently
from
6efd231
to
9684425
Compare
| @@ -170,12 +170,12 @@ service: | |||
| pipelines: | |||
| metrics: | |||
| receivers: [k8s_cluster] | |||
| processors: [memory_limiter, k8sattributes, batch, attributes/observe_common, attributes/debug_source_cluster_metrics] | |||
| processors: [memory_limiter, batch, resource/observe_common, k8sattributes, attributes/debug_source_cluster_metrics] | |||
There was a problem hiding this comment.
same thing here, k8sattributes got moved later in the pipeline
Move observe_common attributes (k8s.cluster.name, k8s.cluster.uid) from attributes to resource_attributes for otellogs.
obs-gh-enricogiorio
force-pushed
the
enrico/resourceAttributesLogs
branch
from
9684425
to
ba12764
Compare
obs-gh-alexlew
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move observe_common attributes (k8s.cluster.name, k8s.cluster.uid) from attributes to resource_attributes for otellogs.