Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add overrides for excludeTargets and includeTargets #234

Merged

Conversation

obs-gh-justindaines
Copy link
Contributor

Adding option to override kube-state-events container with include-target and exclude-target.

Validated with following test values:

containerOverrides:
  excludeTargets:
    - events.k8s.io/v1/events
    - apps/v1/replicasets
  includeTargets:
    - apps/v1/deployments

Copy link
Contributor

github-actions bot commented Oct 1, 2024

The following chart updates are necessary:

diff --git a/charts/events/Chart.yaml b/charts/events/Chart.yaml
index a33f976..17d1b1a 100644
--- a/charts/events/Chart.yaml
+++ b/charts/events/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: events
 description: Observe kubernetes event collection
 type: application
-version: 0.1.27
+version: 0.2.0
 appVersion: v0.11.1
 dependencies:
   - name: endpoint
diff --git a/charts/stack/Chart.lock b/charts/stack/Chart.lock
index 6365b09..94a6b95 100644
--- a/charts/stack/Chart.lock
+++ b/charts/stack/Chart.lock
@@ -7,12 +7,12 @@ dependencies:
   version: 0.3.25
 - name: events
   repository: file://../events
-  version: 0.1.27
+  version: 0.2.0
 - name: proxy
   repository: file://../proxy
   version: 0.1.8
 - name: traces
   repository: file://../traces
   version: 1.0.6
-digest: sha256:30b5d64853145b01712478983b58e676bd470890fc3f1eba9d1a246214934edf
-generated: "2024-10-02T15:58:40.884686-04:00"
+digest: sha256:6df6b041f08a4cbf0c1c4b6100adb097531bcb721f2802b8fa37a2b3ae83f7cf
+generated: "2024-10-02T20:25:58.324801371Z"
diff --git a/charts/stack/Chart.yaml b/charts/stack/Chart.yaml
index 5d8e8db..285e66e 100644
--- a/charts/stack/Chart.yaml
+++ b/charts/stack/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: stack
 description: Observe Kubernetes agent stack
 type: application
-version: 1.0.6
+version: 1.1.0
 dependencies:
   - name: logs
     version: 0.1.33
@@ -13,7 +13,7 @@ dependencies:
     repository: file://../metrics
     condition: metrics.enabled
   - name: events
-    version: 0.1.27
+    version: 0.2.0
     repository: file://../events
     condition: events.enabled
   - name: proxy

@obs-gh-justindaines obs-gh-justindaines force-pushed the jdaines/add-include-exclude-target-overrides branch 4 times, most recently from f41d3f7 to 1177bf0 Compare October 2, 2024 20:07
@obs-gh-justindaines obs-gh-justindaines force-pushed the jdaines/add-include-exclude-target-overrides branch 2 times, most recently from e716a22 to 6e46d08 Compare October 2, 2024 20:36
@obs-gh-abhishekrao
Copy link
Contributor

Also, please see if you can add these flags to the default CI tests in charts/stack/ci/test-values.yaml. That'll help capture if this change introduces any regressions or works as expected.

@obs-gh-justindaines obs-gh-justindaines force-pushed the jdaines/add-include-exclude-target-overrides branch 2 times, most recently from 52952a3 to 42b8d67 Compare October 9, 2024 18:48
@obs-gh-justindaines obs-gh-justindaines requested a review from a team October 23, 2024 14:42
@obs-gh-justindaines obs-gh-justindaines force-pushed the jdaines/add-include-exclude-target-overrides branch from 42b8d67 to e2510a2 Compare October 23, 2024 14:49
@obs-gh-justindaines obs-gh-justindaines merged commit 3d142f7 into main Oct 23, 2024
11 checks passed
@obs-gh-justindaines obs-gh-justindaines deleted the jdaines/add-include-exclude-target-overrides branch October 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants