-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add overrides for excludeTargets and includeTargets #234
Merged
obs-gh-justindaines
merged 1 commit into
main
from
jdaines/add-include-exclude-target-overrides
Oct 23, 2024
Merged
feat: Add overrides for excludeTargets and includeTargets #234
obs-gh-justindaines
merged 1 commit into
main
from
jdaines/add-include-exclude-target-overrides
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following chart updates are necessary:
|
obs-gh-justindaines
force-pushed
the
jdaines/add-include-exclude-target-overrides
branch
4 times, most recently
from
October 2, 2024 20:07
f41d3f7
to
1177bf0
Compare
obs-gh-justindaines
force-pushed
the
jdaines/add-include-exclude-target-overrides
branch
2 times, most recently
from
October 2, 2024 20:36
e716a22
to
6e46d08
Compare
obs-gh-justindaines
requested review from
obs-gh-nikhildua and
obs-gh-abhishekrao
October 2, 2024 20:50
Also, please see if you can add these flags to the default CI tests in |
obs-gh-justindaines
force-pushed
the
jdaines/add-include-exclude-target-overrides
branch
2 times, most recently
from
October 9, 2024 18:48
52952a3
to
42b8d67
Compare
obs-gh-justindaines
force-pushed
the
jdaines/add-include-exclude-target-overrides
branch
from
October 23, 2024 14:49
42b8d67
to
e2510a2
Compare
obs-gh-abhishekrao
approved these changes
Oct 23, 2024
obs-gh-justindaines
deleted the
jdaines/add-include-exclude-target-overrides
branch
October 23, 2024 19:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option to override kube-state-events container with include-target and exclude-target.
Validated with following test values: