Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add xml reporting(experimental) #230

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

obs-gh-nikhildua
Copy link
Contributor

@obs-gh-nikhildua obs-gh-nikhildua commented Sep 25, 2024

Why?

  • We want better reporting for terraform tests in PRs. It's currently hard to see in CI what specific test failed in which job.
  • This change makes it easier to see which test failed and the error the test surfaced without scrolling through logs.
  • We use summary markdown from junit xml file to render the failure in summary screen
  • We also change the naming convention for jobs to better identify things.

Other References:

Collapsing parallel github jobs (to make our CI tests less noisy in PR checks) is coming!
https://github.com/orgs/community/discussions/26246

See example:
Screenshot 2024-11-06 at 3 11 03 PM

Scrolling....

We can see exactly what test failed, where and the output logs without having to scroll through each job logs manually.

Screenshot 2024-11-06 at 3 11 23 PM

Another example showing that test_basic had failed

Screenshot 2024-11-06 at 3 31 02 PM

@obs-gh-nikhildua obs-gh-nikhildua force-pushed the nikhil/add-junit-OB-37007 branch 24 times, most recently from baecbbb to b3d1654 Compare October 2, 2024 18:00
@obs-gh-nikhildua obs-gh-nikhildua force-pushed the nikhil/add-junit-OB-37007 branch 4 times, most recently from 920ee9e to 774d13a Compare November 6, 2024 23:14
@obs-gh-nikhildua obs-gh-nikhildua marked this pull request as ready for review November 6, 2024 23:14
@obs-gh-nikhildua obs-gh-nikhildua changed the title [DRAFT] ci: add json reporting(experimental) ci: add json reporting(experimental) Nov 6, 2024
@obs-gh-nikhildua obs-gh-nikhildua force-pushed the nikhil/add-junit-OB-37007 branch 3 times, most recently from 9f2dcd6 to bcfcbac Compare November 6, 2024 23:16
@obs-gh-nikhildua obs-gh-nikhildua changed the title ci: add json reporting(experimental) ci: add xml reporting(experimental) Nov 6, 2024
@obs-gh-nikhildua obs-gh-nikhildua force-pushed the nikhil/add-junit-OB-37007 branch 5 times, most recently from a22ab4a to b2bdb6b Compare November 6, 2024 23:50
@obs-gh-nikhildua obs-gh-nikhildua marked this pull request as draft November 7, 2024 00:14
@obs-gh-nikhildua obs-gh-nikhildua marked this pull request as ready for review November 7, 2024 00:45
@obs-gh-nikhildua obs-gh-nikhildua merged commit 916774e into main Nov 7, 2024
11 checks passed
@obs-gh-nikhildua obs-gh-nikhildua deleted the nikhil/add-junit-OB-37007 branch November 7, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants