Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): migrate away from static AWS IAM credentials (#1) #13

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat(aws): migrate away from static AWS IAM credentials (#1) #13

merged 2 commits into from
Sep 5, 2023

Conversation

obs-gh-colinhutchinson
Copy link
Contributor

@obs-gh-colinhutchinson obs-gh-colinhutchinson commented Sep 5, 2023 •
edited
Loading

  • feat(aws): terraform to provision a federated role and save it as a github variable
  • feat(gha): swap static AWS IAM credentials with federated credentials
  • fix(cleanup): adjust the manual log group cleanup to match the new naming convention

This PR is coming from my fork because that's where I tested this. Necessary steps before merging

  • manually setting up AWS <-> github OIDC federation
  • manually setup a s3 bucket for the terraform state
  • run the infrastructure terraform

@obs-gh-colinhutchinson
feat(aws): migrate away from static AWS IAM credentials (#1)
198edd3 
* feat(aws): terraform to provision a federated role and save it as a github variable

* feat(gha): swap static AWS IAM credentials with federated credentials

* fix(cleanup): adjust the manual log group cleanup to match the new naming convention
@obs-gh-colinhutchinson obs-gh-colinhutchinson merged commit 6d27139 into observeinc:main Sep 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obs-gh-colinhutchinson