constant numeric x and y for text marks #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Nov 26, 2021
mbostock
reviewed
Nov 26, 2021
|
A question: here we add x and y regardless of the anchor, but we could decide that the sign of the "right" and "bottom" positions should be negated (to go "inset"). I don't know which is the most intuitive. |
Fil
force-pushed
the
fil/constant-text-position
branch
from
59d40a3
to
77ed526
Compare
|
converted to draft with the two questions that came up in review |
… the anchor anchor can be any of "top", "bottom", "left", "right" or combinations such as "top-left" closes #523
Fil
force-pushed
the
fil/constant-text-position
branch
from
8b84b40
to
9e78a97
Compare
|
I've now generalized the feature to dots and images. Not sure if it can/should be done for other marks? |
|
Obsolete. This can be achieved with frameAnchor: left and dx: 10 instead of x: 10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
position the text relative to the anchor
anchor can be any of "top", "bottom", "left", "right" or combinations such as "top-left"
demo: https://observablehq.com/@observablehq/text-facet-alignment-523
closes #523
todo: