Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A channel of explicit symbols does not show in the tip nor has a legend #2239

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

A channel of explicit symbols does not show in the tip nor has a legend #2239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d514313
A channel of explicit symbols does not show in the tip nor has a legend
Fil Nov 19, 2024
20b8179
generalize test
mbostock Nov 23, 2024
49da12a
prettier
mbostock Nov 23, 2024
76733de
oops, fix test
mbostock Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/marks/tip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,8 @@ function getSourceChannels(channels, scales) {
if ((key === "x" || key === "y") && channels.geometry) continue; // ignore x & y on geo
const source = getSource(channels, key);
if (source) {
// Ignore color channels if the values are all literal colors.
if (source.scale == null && source.defaultScale === "color") continue;
// Ignore color/symbol channels if the values are all literal colors/symbols.
if (source.scale == null && ["color", "symbol"].includes(source.defaultScale)) continue;
mbostock marked this conversation as resolved.
Show resolved Hide resolved
sources[key] = source;
}
}
Expand Down
Loading