Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lift side effect up to index.js #2069

Merged
merged 4 commits into from
Jun 3, 2024
Merged

lift side effect up to index.js #2069

merged 4 commits into from
Jun 3, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jun 2, 2024

@mbostock mbostock requested a review from Fil June 2, 2024 23:11
@mbostock mbostock changed the title add index.js to sideEffects lift side effect up to index.js Jun 3, 2024
@mbostock mbostock enabled auto-merge (squash) June 3, 2024 02:46
Fil
Fil reviewed Jun 3, 2024
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
@Fil Fil disabled auto-merge June 3, 2024 07:32
Fil
Fil approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed bug report & repro repo.

I've disabled auto-merging since I have a suggestion, but it LGTM in any case.

@mbostock @Fil
Update src/index.js
dee3060 
Co-authored-by: Philippe Rivière <[email protected]>
@mbostock mbostock enabled auto-merge (squash) June 3, 2024 15:24
@mbostock mbostock merged commit af2c3bb into main Jun 3, 2024
1 check passed
@mbostock mbostock deleted the mbostock/more-side-effects branch June 3, 2024 15:24
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 3, 2024
Open
@x-way x-way mentioned this pull request Jul 3, 2024
Closed
This was referenced Jul 4, 2024
Open
Open
Open
This was referenced Jul 6, 2024
Open
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 20, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 6, 2024
Open
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 28, 2024
Open
@FreeMason9224 FreeMason9224 mentioned this pull request Oct 4, 2024
Open
@NotDutchy NotDutchy mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil