-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tick marker #1892
Merged
Merged
tick marker #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the marker approach is more fruitful, for example to draw a https://observablehq.com/@observablehq/plot-custom-markers It would be nice to find a generic way to customize the size of markers (not just for ticks, but for arrow heads etc). |
mbostock
force-pushed
the
mbostock/error-bar-marker
branch
2 times, most recently
from
October 30, 2023 22:33
8c2a818
to
d8fcd2c
Compare
LGTY @Fil? |
Fil
approved these changes
Oct 31, 2023
Open
mbostock
force-pushed
the
mbostock/error-bar-marker
branch
from
November 2, 2023 01:35
d8fcd2c
to
a0a1e15
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* tick marker * tick marker documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1891 taking the marker approach. The downside is that the length of the tick is not configurable; it instead scales with the strokeWidth. The upside is that you can apply the tick marker to a line, but I’m not sure if that’s actually useful. Fixes #1874.