Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tick marker #1892

Merged
merged 2 commits into from
Nov 2, 2023
Merged

tick marker #1892

merged 2 commits into from
Nov 2, 2023

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Oct 12, 2023

Alternative to #1891 taking the marker approach. The downside is that the length of the tick is not configurable; it instead scales with the strokeWidth. The upside is that you can apply the tick marker to a line, but I’m not sure if that’s actually useful. Fixes #1874.

@mbostock mbostock requested a review from Fil October 12, 2023 05:11
@Fil
Copy link
Contributor

Fil commented Oct 12, 2023

I think the marker approach is more fruitful, for example to draw a barbed wire railroad track line
Capture d’écran 2023-10-12 à 15 07 28

https://observablehq.com/@observablehq/plot-custom-markers

It would be nice to find a generic way to customize the size of markers (not just for ticks, but for arrow heads etc).

@mbostock mbostock force-pushed the mbostock/error-bar-marker branch 2 times, most recently from 8c2a818 to d8fcd2c Compare October 30, 2023 22:33
@mbostock
Copy link
Member Author

LGTY @Fil?

@Fil Fil mentioned this pull request Oct 31, 2023
@mbostock mbostock enabled auto-merge (squash) November 2, 2023 01:35
@mbostock mbostock merged commit 32462b1 into main Nov 2, 2023
1 check passed
@mbostock mbostock deleted the mbostock/error-bar-marker branch November 2, 2023 01:37
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* tick marker

* tick marker documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error bars
2 participants