Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move imports to _import #136

Merged
merged 2 commits into from
Nov 9, 2023
Merged

move imports to _import #136

merged 2 commits into from
Nov 9, 2023

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Nov 9, 2023

This lays some groundwork for rewriting imported local modules, such as for #115. Rather than moving imported modules into the _file folder alongside file attachments, we move them to an _import folder. In a followup change, this will allow the Preview server to intercept request for imported ES modules and rewrite them on the fly, and likewise we can rewrite them during build.

@mbostock mbostock requested a review from cinxmo November 9, 2023 17:20
@mbostock mbostock mentioned this pull request Nov 9, 2023
6 tasks
@mbostock mbostock merged commit 63f0d42 into main Nov 9, 2023
1 check passed
@mbostock mbostock deleted the mbostock/rewrite-local-imports branch November 9, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants