Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template functions #84

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Add template functions #84

merged 3 commits into from
Aug 7, 2020

Conversation

jmwilliams89
Copy link
Contributor

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

Copy link
Contributor

@camdencheek camdencheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. That was simpler than I was expecting

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 3.0345325 -0.7931738 28.599676 -0.413929
1 5000 7.775998 -1.0519123 41.2205 +0.7416496
1 10000 13.069195 -0.948472 52.00283 -2.555088
1 10000 13.569379 -0.44828796 53.08486 -1.4730568
1 50000 57.93423 -0.108695984 206.72562 +38.363678
1 100000 104.87287 -3.327034 276.23236 -3.736786
10 100 5.1725864 +0.4655733 31.218212 +0.004983902
10 100 5.03457 +0.3275571 30.897224 -0.3160038
10 500 9.276021 -1.0689545 38.251347 -1.9016724
10 1000 15.327847 +0.2413845 54.2896 +3.4014015
10 5000 63.17062 -4.056118 149.4771 -2.3581696
10 5000 65.881 -1.3457413 201.73734 +49.90207
10 10000 116.75259 -16.86567 330.24112 -4.8153076

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #84 into master will decrease coverage by 0.05%.
The diff coverage is 55.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   74.62%   74.57%   -0.05%     
==========================================
  Files          66       66              
  Lines        3983     3991       +8     
==========================================
+ Hits         2972     2976       +4     
- Misses        760      764       +4     
  Partials      251      251              
Impacted Files Coverage Δ
operator/plugin.go 90.80% <55.56%> (-4.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9e626...24b7cdf. Read the comment docs.

@jmwilliams89 jmwilliams89 merged commit f1d4bd9 into master Aug 7, 2020
@jmwilliams89 jmwilliams89 deleted the add-template-functions branch August 7, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants