Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing integer types to protobuf conversion #82

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

camdencheek
Copy link
Contributor

Description of Changes

Add the remaining integer types to the Google Cloud output protobuf conversion.

The recent addition of EventID to the Windows Event plugin caused a regression because it used uint16, which was not enumerated in the switch statement.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@camdencheek camdencheek force-pushed the google-cloud-uint16 branch from b1bfd4b to b990514 Compare August 7, 2020 18:31
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 3.275912 -0.12069845 25.05738 -0.18372917
1 5000 7.4485354 -0.74135065 41.453663 +3.7746506
1 10000 13.500042 -0.25875282 51.264683 -1.3946648
1 50000 57.726242 -0.3785324 180.50996 -9.928482
1 100000 110.62324 +3.6856155 297.46295 +20.808868
10 100 4.9138956 -0.27589703 29.164062 +0.1619072
10 500 9.086357 -1.0345802 41.2368 +1.3239517
10 1000 16.241722 -0.2069645 54.281925 +0.7648201
10 5000 62.62099 -3.156376 198.18965 +26.22319
10 10000 115.8604 -4.9816284 326.90747 +9.5043335

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #82 into master will decrease coverage by 0.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   74.96%   74.62%   -0.34%     
==========================================
  Files          66       66              
  Lines        3973     3983      +10     
==========================================
- Hits         2978     2972       -6     
- Misses        745      760      +15     
- Partials      250      251       +1     
Impacted Files Coverage Δ
operator/builtin/output/google_cloud.go 41.67% <0.00%> (-1.91%) ⬇️
operator/builtin/input/journald.go 53.64% <0.00%> (-3.64%) ⬇️
operator/builtin/input/file/read_to_end.go 59.70% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3760d8...b990514. Read the comment docs.

@camdencheek camdencheek merged commit eb9e626 into master Aug 7, 2020
@camdencheek camdencheek deleted the google-cloud-uint16 branch August 7, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants