-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bug): create /usr/local/bin if not present #614
Conversation
…ix install script
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage ? 74.98%
=======================================
Files ? 133
Lines ? 10089
Branches ? 0
=======================================
Hits ? 7565
Misses ? 2054
Partials ? 470 Continue to review full report at Codecov.
|
Do we even want to put a link in this directory if it doesn't exist? I imagine this is to make it so that stanza is on your path, does creating the directory and linking actually do that on the affected systems? |
README.md
Outdated
@@ -104,6 +104,7 @@ Restart Stanza: `sudo systemctl restart stanza`. | |||
- Single command install, requires the `curl` command | |||
- Stanza will automatically be running as a service | |||
- On Linux, Stanza will be running as the `root` user. On Macos, Stanza will be running as your current user. | |||
- `sudo` may be required if user running installer needs permission to write to installation locations and linking to `/usr/local/bin`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sudo is always required for Linux, and will be required for macos if the user does not have write permission to /usr/local/bin.
I agree with this generally, just am thinking about any current users that maybe built automation around expecting it being in |
1ffe1d0
Description of Changes
/usr/local/bin
present when they run the installer. So this PR addresses this by ensuring the directory exists before linking the installed binary to the $PATHTested on linux by removing the /usr/local/bin and rerunning the installer whereas on
main
it failed.From my understanding it is the responsibility of the third party app in the macOS ecosystem to create the folder if it wishes to add things to
/usr/local/bin
https://discussions.apple.com/thread/252495484Please check that the PR fulfills these requirements