-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(dependabot): Dependencies updates #599
Conversation
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
136d92d
to
7fa0cf6
Compare
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage ? 74.91%
=======================================
Files ? 133
Lines ? 10089
Branches ? 0
=======================================
Hits ? 7558
Misses ? 2065
Partials ? 466 Continue to review full report at Codecov.
|
@@ -19,7 +19,7 @@ install-tools: | |||
cd $(TOOLS_MOD_DIR) && go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment | |||
cd $(TOOLS_MOD_DIR) && go install github.com/observiq/amazon-log-agent-benchmark-tool/cmd/logbench | |||
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser | |||
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1 | |||
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally a fan of pinning a version, now looking at this it seems like its kind of hodge-podge. Any strong reason why we are unpinning this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh noticed the internal/tools/go.mod nvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's pinned in the go.mod file in internal tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol yup I just noticed you figured out that. Resolving this.
@@ -19,7 +19,7 @@ install-tools: | |||
cd $(TOOLS_MOD_DIR) && go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment | |||
cd $(TOOLS_MOD_DIR) && go install github.com/observiq/amazon-log-agent-benchmark-tool/cmd/logbench | |||
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser | |||
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1 | |||
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh noticed the internal/tools/go.mod nvm
Description of Changes
Manually updated dependabot prs:
Please check that the PR fulfills these requirements