Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(dependabot): Dependencies updates #599

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Conversation

@cpheps cpheps requested a review from a team as a code owner March 8, 2022 14:26
@cpheps cpheps requested a review from schmikei March 8, 2022 14:26
dehaansa
dehaansa previously approved these changes Mar 8, 2022
Corbin Phelps added 6 commits March 8, 2022 09:31
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@33707f8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage        ?   74.91%           
=======================================
  Files           ?      133           
  Lines           ?    10089           
  Branches        ?        0           
=======================================
  Hits            ?     7558           
  Misses          ?     2065           
  Partials        ?      466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33707f8...7fa0cf6. Read the comment docs.

@@ -19,7 +19,7 @@ install-tools:
cd $(TOOLS_MOD_DIR) && go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment
cd $(TOOLS_MOD_DIR) && go install github.com/observiq/amazon-log-agent-benchmark-tool/cmd/logbench
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally a fan of pinning a version, now looking at this it seems like its kind of hodge-podge. Any strong reason why we are unpinning this here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh noticed the internal/tools/go.mod nvm

Copy link
Contributor Author

@cpheps cpheps Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pinned in the go.mod file in internal tools

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yup I just noticed you figured out that. Resolving this.

@@ -19,7 +19,7 @@ install-tools:
cd $(TOOLS_MOD_DIR) && go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment
cd $(TOOLS_MOD_DIR) && go install github.com/observiq/amazon-log-agent-benchmark-tool/cmd/logbench
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh noticed the internal/tools/go.mod nvm

@cpheps cpheps merged commit 93c9769 into main Mar 8, 2022
@cpheps cpheps deleted the dependabot-2022-03-08 branch March 8, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants