Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ehanced parameter metadata to include concepts of required/optional, … #59

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Jul 27, 2020

…default values, and specific parameter types

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

…default values, and specific parameter types
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #59 into master will increase coverage by 0.29%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   74.94%   75.23%   +0.29%     
==========================================
  Files          63       64       +1     
  Lines        3835     3940     +105     
==========================================
+ Hits         2874     2964      +90     
- Misses        718      731      +13     
- Partials      243      245       +2     
Impacted Files Coverage Δ
operator/plugin_parameter.go 84.21% <84.21%> (ø)
operator/plugin.go 94.94% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e137723...2a41112. Read the comment docs.

@djaglowski djaglowski marked this pull request as ready for review July 28, 2020 15:21
operator/plugin.go Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Average (%) Memory Average (MB)
1 1000 2.793206 27.805225
1 5000 5.7759795 31.726562
1 10000 10.034738 44.04068
1 50000 37.74265 105.8917
1 100000 71.0124 176.01683
10 100 3.9829555 29.328125
10 500 8.344965 36.56102
10 1000 12.276159 41.660965
10 5000 46.363155 97.72952
10 10000 80.98528 189.02129

@djaglowski djaglowski merged commit 0718f05 into master Jul 28, 2020
@djaglowski djaglowski deleted the plugin-parameters branch July 28, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants