Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and Test Windows MSI during release #569

Merged
merged 60 commits into from
Mar 1, 2022
Merged

Build and Test Windows MSI during release #569

merged 60 commits into from
Mar 1, 2022

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Feb 21, 2022

Description of Changes

Implemented MSI building. The MSI package can be used to install, repair, and uninstall stanza.

Codebase Changes

  • Added optional environment variables for log file path and database file path. This is because go-msi does not handle arguments very well when the path has spaces in it. Quoting should work but I get a strange wix error. Instead, I use environment variables to enable the log and database files.

Build Changes

  • Added make targets for using vagrant to build an MSI package.
  • Modified the release workflow to run on PR.
  • Added condition to release workflow "release" and "build container" stages to ensure they only run on a tagged release.
  • Added MSI building to release workflow, it will run on PR and pushed tag. The release stage will wait for the msi build, and then download the msi artifcats and bundle it with the Goreleaser release.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #569 (3bca623) into master (3b23e5c) will decrease coverage by 1.71%.
The diff coverage is 87.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   76.69%   74.98%   -1.71%     
==========================================
  Files         132      133       +1     
  Lines        8308    10086    +1778     
==========================================
+ Hits         6371     7562    +1191     
- Misses       1473     2059     +586     
- Partials      464      465       +1     
Impacted Files Coverage Δ
operator/buffer/buffer.go 75.86% <ø> (-1.92%) ⬇️
operator/buffer/memory.go 71.60% <ø> (-3.74%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <ø> (-6.82%) ⬇️
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/azure/event_hub_config.go 90.91% <ø> (-1.09%) ⬇️
operator/builtin/input/file/finder.go 100.00% <ø> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/http/config.go 97.56% <ø> (-0.29%) ⬇️
operator/builtin/input/journald/journald.go 58.76% <ø> (-1.83%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6410e79...3bca623. Read the comment docs.

@jsirianni jsirianni marked this pull request as ready for review February 22, 2022 18:37
@jsirianni jsirianni requested a review from a team as a code owner February 22, 2022 18:37
@cpheps cpheps self-requested a review February 23, 2022 13:17
.github/workflows/release.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
build/windows/config.yaml Outdated Show resolved Hide resolved
@jsirianni jsirianni requested a review from cpheps February 23, 2022 16:01
cpheps
cpheps previously approved these changes Feb 25, 2022
docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
@jsirianni jsirianni changed the title Build and Test Windows MSI Build and Test Windows MSI during release Feb 28, 2022
@jsirianni jsirianni merged commit a5b004b into master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants