Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Revive Linter #564

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Add Revive Linter #564

merged 5 commits into from
Feb 18, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Feb 18, 2022

Description of Changes

  • Removed golangci-lint in favor of revive linter
  • Added github action to run linter
  • Fixed linter issues

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

Corbin Phelps added 4 commits February 18, 2022 10:17
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
@cpheps cpheps requested a review from a team as a code owner February 18, 2022 15:25
@cpheps cpheps requested a review from StefanKurek February 18, 2022 15:25
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #564 (23d7ae8) into master (3b23e5c) will decrease coverage by 1.90%.
The diff coverage is 68.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   76.69%   74.78%   -1.90%     
==========================================
  Files         132      132              
  Lines        8308     9993    +1685     
==========================================
+ Hits         6371     7473    +1102     
- Misses       1473     2057     +584     
+ Partials      464      463       -1     
Impacted Files Coverage Δ
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
operator/builtin/output/forward/forward.go 56.70% <0.00%> (-3.79%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.62% <33.33%> (-2.76%) ⬇️
operator/builtin/input/generate/generate.go 79.10% <66.67%> (-1.60%) ⬇️
cmd/stanza/service.go 62.16% <100.00%> (-5.48%) ⬇️
entry/nil_field.go 100.00% <100.00%> (ø)
operator/buffer/disk.go 68.37% <100.00%> (-0.18%) ⬇️
operator/buffer/disk_metadata.go 36.50% <100.00%> (-5.81%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7350d...23d7ae8. Read the comment docs.

dehaansa
dehaansa previously approved these changes Feb 18, 2022
operator/builtin/input/file/rotation_test.go Outdated Show resolved Hide resolved
revive/config.toml Outdated Show resolved Hide resolved
Signed-off-by: Corbin Phelps <[email protected]>
@cpheps
Copy link
Contributor Author

cpheps commented Feb 18, 2022

CI failures unrelated to PR changes.

@cpheps cpheps merged commit 8733932 into master Feb 18, 2022
@cpheps cpheps deleted the revive-linter branch February 18, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants