Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to contributing.md #562

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Small change to contributing.md #562

merged 2 commits into from
Feb 18, 2022

Conversation

schmikei
Copy link
Contributor

Description of Changes

We now require two approvers per merge of PR

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@schmikei schmikei requested a review from a team as a code owner February 18, 2022 15:00
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #562 (61fc2ee) into master (3b23e5c) will decrease coverage by 1.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   76.69%   74.72%   -1.97%     
==========================================
  Files         132      132              
  Lines        8308    10000    +1692     
==========================================
+ Hits         6371     7472    +1101     
- Misses       1473     2064     +591     
  Partials      464      464              
Impacted Files Coverage Δ
version/version.go 25.00% <0.00%> (-8.33%) ⬇️
cmd/stanza/graph.go 47.22% <0.00%> (-7.62%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <0.00%> (-6.82%) ⬇️
operator/buffer/disk_metadata.go 35.71% <0.00%> (-6.59%) ⬇️
...tor/builtin/transformer/restructure/restructure.go 70.17% <0.00%> (-6.50%) ⬇️
operator/helper/persister.go 70.59% <0.00%> (-6.16%) ⬇️
operator/builtin/transformer/metadata/metadata.go 60.53% <0.00%> (-6.14%) ⬇️
operator/builtin/input/file/file.go 74.90% <0.00%> (-5.82%) ⬇️
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/helper/input.go 68.75% <0.00%> (-5.61%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ea544...61fc2ee. Read the comment docs.

Copy link
Contributor

@BinaryFissionGames BinaryFissionGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll also need to take a closer look at a couple more of these docs, particularly the maintainer stuff.

@schmikei schmikei merged commit ba7350d into master Feb 18, 2022
@schmikei schmikei deleted the small-doc-update branch February 18, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants