Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled fail fast for tests #560

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Disabled fail fast for tests #560

merged 1 commit into from
Feb 17, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Feb 17, 2022

Description of Changes

Disabled fail-fast in test ci/cd to allow all three oses to run to completion.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

Signed-off-by: Corbin Phelps <[email protected]>
@Mrod1598 Mrod1598 self-requested a review February 17, 2022 15:49
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #560 (52bac50) into master (3b23e5c) will decrease coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   76.69%   74.75%   -1.94%     
==========================================
  Files         132      132              
  Lines        8308    10000    +1692     
==========================================
+ Hits         6371     7475    +1104     
- Misses       1473     2062     +589     
+ Partials      464      463       -1     
Impacted Files Coverage Δ
version/version.go 25.00% <0.00%> (-8.33%) ⬇️
cmd/stanza/graph.go 47.22% <0.00%> (-7.62%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <0.00%> (-6.82%) ⬇️
operator/buffer/disk_metadata.go 35.71% <0.00%> (-6.59%) ⬇️
...tor/builtin/transformer/restructure/restructure.go 70.17% <0.00%> (-6.50%) ⬇️
operator/helper/persister.go 70.59% <0.00%> (-6.16%) ⬇️
operator/builtin/transformer/metadata/metadata.go 60.53% <0.00%> (-6.14%) ⬇️
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/helper/input.go 68.75% <0.00%> (-5.61%) ⬇️
cmd/stanza/service.go 62.16% <0.00%> (-5.48%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e101604...52bac50. Read the comment docs.

@cpheps
Copy link
Contributor Author

cpheps commented Feb 17, 2022

CI Test failures are related to known flaky tests unrelated to this PR. Merging.

@cpheps cpheps merged commit 65ff8ca into master Feb 17, 2022
@cpheps cpheps deleted the fail-fast-disable branch February 17, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants