-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try tweaking some times to reduce flakiness #558
Conversation
92c9be3
to
9128643
Compare
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 76.69% 74.73% -1.95%
==========================================
Files 132 132
Lines 8308 9993 +1685
==========================================
+ Hits 6371 7468 +1097
- Misses 1473 2056 +583
- Partials 464 469 +5
Continue to review full report at Codecov.
|
Ran 5 successful tests in a row; Empirically, using the tests cases exactly as the are from https://github.com/open-telemetry/opentelemetry-log-collection seems much more stable. It's not 100% transparent to me why it's more stable, however. |
379d532
to
c028270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that just tweaking time values makes it work is a bit of a code smell but I'm ok with this being a temporary mitigation.
e4ff769
c028270
to
e4ff769
Compare
https://github.com/observIQ/stanza/runs/5249699444 Another failure, on windows of course. I'll come back to this in a bit. |
2f77130
2f77130
to
e387948
Compare
@cpheps I looked into it a bit closer since I got some test failures locally at some point (some tests will actually deadlock if they fail by not polling a log entry fast enough, which confused me), and yeah, it's just generally hard to test these things better with how the file input operator is right now. A future goal might be refactoring a bit and have this better testable, and rewriting some of these tests so they aren't so reliant on timeouts. |
e387948
to
c97bd1a
Compare
Using this PR to try testing some changes to tests to reduce flakiness, since they don't seem to flake locally.