Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make test #556

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix make test #556

merged 1 commit into from
Feb 17, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Description of Changes

make test doesn't work because the command is where requirements should be, needs a newline

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #556 (bd2f978) into master (3b23e5c) will decrease coverage by 1.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   76.69%   74.78%   -1.91%     
==========================================
  Files         132      132              
  Lines        8308    10000    +1692     
==========================================
+ Hits         6371     7478    +1107     
- Misses       1473     2053     +580     
- Partials      464      469       +5     
Impacted Files Coverage Δ
version/version.go 25.00% <0.00%> (-8.33%) ⬇️
cmd/stanza/graph.go 47.22% <0.00%> (-7.62%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <0.00%> (-6.82%) ⬇️
operator/buffer/disk_metadata.go 35.71% <0.00%> (-6.59%) ⬇️
...tor/builtin/transformer/restructure/restructure.go 70.17% <0.00%> (-6.50%) ⬇️
operator/helper/persister.go 70.59% <0.00%> (-6.16%) ⬇️
operator/builtin/transformer/metadata/metadata.go 60.53% <0.00%> (-6.14%) ⬇️
operator/builtin/input/file/file.go 74.90% <0.00%> (-5.82%) ⬇️
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/helper/input.go 68.75% <0.00%> (-5.61%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55abccb...bd2f978. Read the comment docs.

@BinaryFissionGames BinaryFissionGames merged commit e101604 into master Feb 17, 2022
@BinaryFissionGames BinaryFissionGames deleted the fix-make-test branch February 25, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants