Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google split #521

Merged
merged 4 commits into from
Jan 3, 2022
Merged

Google split #521

merged 4 commits into from
Jan 3, 2022

Conversation

armstrmi
Copy link
Contributor

@armstrmi armstrmi commented Jan 3, 2022

Description of Changes

  • updated splitting algorithm to instead fill each request before making a new one
  • included new benchmark test to check that speed of algorithm didn't consume too much time

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes


if firstSize > g.MaxRequestSize {
index = i
firstRequest.Entries = firstRequest.Entries[0:index]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but little Go shortcut [:index] is the same as [0:index] omitting the first value defaults to zero and omitting the last value defaults to the last index.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.9656678 +0.29327285 130.7865 -0.08351135
1 5000 5.965612 +0.068957806 137.25754 -0.9908447
1 10000 11.241477 -1.120678 143.79782 -3.5045776
1 50000 57.397747 -5.827301 179.75134 +4.8547974
1 100000 147.90382 +16.746399 236.19827 +1.6165161
10 100 2.1207376 +6.914139e-06 132.12904 -2.516693
10 500 7.6898756 +0.79309225 142.10237 +0.4636383
10 1000 13.379507 +0.5172796 144.48329 -3.776413
10 5000 66.00097 -1.8442001 175.45999 -0.9073334
10 10000 133.3317 -3.0996246 224.40019 -14.2105255

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.7413743 +0.1205771 131.58014 +1.3775482
1 5000 6.034586 +0.120700836 136.092 -2.6373901
1 10000 11.827562 +0.896327 146.20312 +1.7652283
1 50000 63.847515 -1.3422966 177.15355 +0.8943939
1 100000 125.87989 +14.823784 253.5664 +38.837418
10 100 2.189656 -0.275944 134.58742 +2.0507812
10 500 8.034476 +1.18962 136.81479 -6.0476837
10 1000 13.603749 +0.58631897 145.84886 +0.3674469
10 5000 67.20832 -0.5163574 175.20905 -0.5882263
10 10000 139.68756 +2.128128 241.9332 +14.689926

@armstrmi armstrmi merged commit f4a1195 into master Jan 3, 2022
@armstrmi armstrmi deleted the google-split branch January 3, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants