Add support for alternative encodings #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for all encodings supported by the `x/text/encoding` package. This can be configured with the new `encoding` parameter of the file input. A limitation of the current implementation is that it does not respect the BOM in UTF16, so users will have to explicitly choose `utf-16le` or `utf16-be`
camdencheek
force-pushed
the
multibyte-character
branch
from
a2db099 to
6b0fccc
Compare
|
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 75.44% 75.30% -0.14%
==========================================
Files 61 61
Lines 3718 3753 +35
==========================================
+ Hits 2805 2826 +21
- Misses 690 697 +7
- Partials 223 230 +7
Continue to review full report at Codecov.
|
djaglowski
approved these changes
Jul 20, 2020
| @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## Unreleased | |||
There was a problem hiding this comment.
Good idea to capture it this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This commit adds support for all encodings supported by the
x/text/encodingpackage. This can be configured with the newencodingparameter of the file input.A limitation of the current implementation is that it does not respect
the BOM in UTF16, so users will have to explicitly choose
utf-16leorutf16-beDescription of Changes
Please check that the PR fulfills these requirements