Make journald emit map[string]interface{} #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
It turns out our
entry.Field
doesn't handle iterating throughmap[string]string
well. We ran into this because thejournald
plugin emitsmap[string]string
. This PR changes thejournald
input to be more in line with the other plugins so that it emits amap[string]interface{}
.This seems to be part of a larger recurring issue with the types that are allowed in our pipeline. We should really consider locking down the types that are allowed into the record in the first place. It's impossible to handle every type, and if we don't have any standards, it's unclear what is and is not expected to be handled by each of the downstream plugins.
Please check that the PR fulfills these requirements