Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port otel enhanced file input benchmarking #344

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jun 25, 2021

Description of Changes

See open-telemetry/opentelemetry-log-collection#166

This pr builds on

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni mentioned this pull request Jun 25, 2021
4 tasks
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.51735 +0.0173316 129.29121 +2.598999
1 5000 5.1208787 +0.39660645 139.43602 -0.8009186
1 10000 9.948323 -1.1039886 142.7597 -0.8887329
1 50000 50.64128 +5.367012 176.24272 +4.3729706
1 100000 91.70903 -0.41596222 238.54216 +0.7741089
10 100 1.8103399 +0.017153502 136.12958 +2.630661
10 500 5.9828787 +0.6207857 140.17363 -0.171875
10 1000 11.758782 -0.2244091 149.38496 +0.84010315
10 5000 55.034863 -0.7258339 177.38187 -0.6641998
10 10000 105.143845 +5.9057083 229.44545 -5.280716

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #344 (e51a2ae) into master (f9245d9) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   69.64%   69.41%   -0.23%     
==========================================
  Files         123      123              
  Lines        6495     6496       +1     
==========================================
- Hits         4523     4509      -14     
- Misses       1498     1512      +14     
- Partials      474      475       +1     
Impacted Files Coverage Δ
operator/builtin/input/file/config.go 75.38% <100.00%> (-2.74%) ⬇️
logger/parser.go 56.52% <0.00%> (-17.39%) ⬇️
operator/builtin/input/tcp/tcp.go 69.30% <0.00%> (-4.39%) ⬇️
operator/builtin/input/file/file.go 73.79% <0.00%> (-2.07%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9245d9...e51a2ae. Read the comment docs.

@jsirianni jsirianni mentioned this pull request Jun 25, 2021
4 tasks
@jsirianni jsirianni marked this pull request as ready for review June 25, 2021 15:20
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.46551 -0.06899297 130.25714 +2.6558456
1 5000 5.224235 -0.3620758 135.8851 +0.474411
1 10000 9.999927 +0.58596706 144.55455 +0.5897064
1 50000 46.328697 -2.2407722 175.41716 +2.9863892
1 100000 90.68924 -6.3656464 231.65652 -5.4074554
10 100 1.8103532 -0.017219901 132.49043 -0.41392517
10 500 6.0000544 +0.017110825 141.3129 +1.062088
10 1000 10.741545 -1.2238941 146.33836 -1.9544678
10 5000 50.36356 +0 180.27519 +0
10 10000 99.72423 -7.9164124 226.80212 -1.9042358

@jsirianni jsirianni requested a review from djaglowski June 25, 2021 16:19
@jsirianni jsirianni merged commit 4fdb879 into master Jun 25, 2021
@jsirianni jsirianni deleted the port-otel-file-input branch June 25, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants