Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows event log errors returned by publisher.Open #334

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jun 21, 2021

Description of Changes

There is one spot in windows event where we do not log the error

This results in: Failed to open publisher: %s" when calls to publisher.Open return an error.

{"level":"error","ts":"2021-06-21T11:25:11.485-0700","msg":"Failed to open publisher: %s","operator_id":"$.9e96dcdf-012e-4636-8235-7c11f48e9966.application_event_input","operator_type":"windows_eventlog_input"}

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni requested a review from djaglowski June 21, 2021 20:10
djaglowski
djaglowski previously approved these changes Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #334 (6974e3a) into master (762bf14) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   69.67%   69.61%   -0.06%     
==========================================
  Files         123      123              
  Lines        6489     6489              
==========================================
- Hits         4521     4517       -4     
- Misses       1494     1499       +5     
+ Partials      474      473       -1     
Impacted Files Coverage Δ
operator/builtin/input/file/file.go 75.86% <0.00%> (-2.76%) ⬇️
operator/builtin/output/forward/forward.go 55.07% <0.00%> (-1.45%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.96% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762bf14...6974e3a. Read the comment docs.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.3448383 -0.24142301 127.86571 +0.76872253
1 5000 4.793261 +0.2760296 138.4053 +0.43170166
1 10000 9.327618 +0.06888485 146.89642 +1.6436005
1 50000 50.25919 +3.310112 175.80118 +1.8846893
1 100000 98.42004 -1.9034729 242.78206 +1.2533722
10 100 1.8621321 -0.051759124 134.09805 +3.1601562
10 500 6.0345683 -0.18964052 141.33647 +1.618927
10 1000 11.586237 -0.46560764 147.69478 +0.80604553
10 5000 49.776756 +0.08617401 176.4441 -0.45796204
10 10000 106.203545 +6.0505295 230.0555 +5.225479

@jsirianni jsirianni merged commit 7b82912 into master Jun 21, 2021
@jsirianni jsirianni deleted the windows-input-log-error branch June 21, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants