-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move multiline handling from file input to helper package #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiline to be used by other operators such as tcp and udp input
|
…nza. Remove map structure tests as they are not implemented yet.
|
|
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 70.09% 70.04% -0.05%
==========================================
Files 119 121 +2
Lines 6330 6369 +39
==========================================
+ Hits 4437 4461 +24
- Misses 1422 1443 +21
+ Partials 471 465 -6
Continue to review full report at Codecov.
|
|
djaglowski
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Before adding multiline support to TCP / UDP input, we need to pull multiline handling out of file input and into helper. This was already implemented in Open Telemetry: open-telemetry/opentelemetry-log-collection#125
TCP and UDP multiline support will come after this PR is merged.
Please check that the PR fulfills these requirements