Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single module repo #304

Merged
merged 3 commits into from
May 24, 2021
Merged

Single module repo #304

merged 3 commits into from
May 24, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented May 18, 2021

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni mentioned this pull request May 18, 2021
4 tasks
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4483358 -0.24128938 130.96255 +1.5402832
1 5000 5.258661 -0.5344386 138.37715 +3.0628967
1 10000 10.758828 +0.29324532 146.16367 +1.4321136
1 50000 55.556213 +5.4357033 177.29364 +3.8576202
1 100000 94.582886 -6.8279724 222.29958 -11.669983
10 100 2.1896613 +0.24136925 133.95892 +0.86450195
10 500 6.138134 -0.3791833 139.20932 -0.22198486
10 1000 11.569029 -0.20697784 144.88524 -1.1788788
10 5000 55.363754 -0.9312477 179.02155 -6.6829224
10 10000 112.4333 +6.467743 231.68251 +8.147888

@jsirianni jsirianni requested a review from djaglowski May 18, 2021 21:29
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #304 (2a0910e) into master (32e97be) will increase coverage by 0.81%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   69.34%   70.14%   +0.81%     
==========================================
  Files         119      119              
  Lines        6333     6330       -3     
==========================================
+ Hits         4391     4440      +49     
+ Misses       1479     1420      -59     
- Partials      463      470       +7     
Impacted Files Coverage Δ
version/version.go 20.00% <20.00%> (-30.00%) ⬇️
operator/builtin/input/tcp/tcp.go 69.30% <0.00%> (-4.39%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️
...perator/builtin/output/googlecloud/google_cloud.go 55.15% <0.00%> (+0.61%) ⬆️
operator/builtin/input/file/config.go 80.65% <0.00%> (+1.08%) ⬆️
operator/builtin/output/forward/forward.go 56.52% <0.00%> (+1.45%) ⬆️
operator/helper/time.go 78.15% <0.00%> (+1.99%) ⬆️
operator/builtin/parser/regex/regex.go 100.00% <0.00%> (+2.27%) ⬆️
operator/helper/severity.go 84.62% <0.00%> (+2.56%) ⬆️
operator/builtin/output/otlp/otlp.go 65.43% <0.00%> (+3.70%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e97be...2a0910e. Read the comment docs.

djaglowski
djaglowski previously approved these changes May 19, 2021
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.3448567 -0.05169344 128.5027 +0.041625977
1 5000 4.7759843 +0.12083769 135.91998 -0.43171692
1 10000 9.258757 -0.12062454 143.63496 +1.1367188
1 50000 45.691193 -7.103939 173.08257 -1.6581421
1 100000 96.07262 +6.0178604 235.61772 +4.839981
10 100 1.810369 -0.034524083 130.49515 -0.68588257
10 500 6.051823 -0.1895876 142.12971 +4.395874
10 1000 12.12102 +0.27600288 145.67403 +2.6299744
10 5000 51.18072 -5.715 174.61139 -10.510376
10 10000 95.903305 -9.030098 220.37405 +0.20756531

@jsirianni jsirianni requested a review from djaglowski May 24, 2021 16:13
@jsirianni jsirianni merged commit c0384a9 into master May 24, 2021
@jsirianni jsirianni deleted the single-module-repo branch May 24, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set stanza version during build based on git tag
2 participants