Fix reading partial logs in active files #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logs are actively being written to, we can't assume that an EOF is a valid log entry terminator since the application writing could have written a partial entry. This commit changes our logic so we only read to the end of the file if both the offset and the file size haven't changed since the last time we polled. This gives applications as long as the poll interval to write an entire log entry.
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 75.62% 75.66% +0.04%
==========================================
Files 61 61
Lines 3601 3632 +31
==========================================
+ Hits 2723 2748 +25
- Misses 654 658 +4
- Partials 224 226 +2
Continue to review full report at Codecov.
|
jmwilliams89
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When logs are actively being written to, we can't assume that an EOF
is a valid log entry terminator since the application writing could
have written a partial entry.
This commit changes our logic so we only read to the end of the file
if both the offset and the file size haven't changed since the last time
we polled. This gives applications as long as the poll interval to write
an entire log entry.
Description of Changes
Please check that the PR fulfills these requirements