Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules #108

Merged
merged 97 commits into from
Sep 11, 2020
Merged

Submodules #108

merged 97 commits into from
Sep 11, 2020

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Sep 1, 2020

Description of Changes

  • Separate executable code and distributable code into modules.
  • Separates most builtin operators into individual modules. This allows each to be imported (or not), which provides more granular control over dependencies that are pulled into another project.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@observIQ observIQ deleted a comment from codecov bot Sep 1, 2020
@observIQ observIQ deleted a comment from codecov bot Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #108 into master will decrease coverage by 1.59%.
The diff coverage is 85.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   71.98%   70.39%   -1.59%     
==========================================
  Files          78       80       +2     
  Lines        5050     4965      -85     
==========================================
- Hits         3635     3495     -140     
- Misses       1057     1159     +102     
+ Partials      358      311      -47     
Impacted Files Coverage Δ
cmd/stanza/default_paths.go 59.09% <ø> (ø)
cmd/stanza/logging.go 50.00% <ø> (ø)
cmd/stanza/main.go 0.00% <0.00%> (ø)
cmd/stanza/root.go 42.59% <ø> (ø)
cmd/stanza/version.go 62.50% <ø> (ø)
operator/buffer/memory.go 81.13% <ø> (ø)
operator/builtin/input/generate/generate.go 81.03% <ø> (ø)
operator/builtin/input/journald/journald.go 53.64% <ø> (ø)
operator/builtin/input/k8sevent/k8s_event.go 40.16% <ø> (ø)
operator/builtin/input/tcp/tcp.go 72.22% <ø> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67cf06...9bc0838. Read the comment docs.

@@ -138,7 +138,31 @@ jobs:
- run:
name: Unit Tests
shell: powershell.exe
command: go test -race -coverprofile coverage.txt -coverpkg ./... ./...
command: >
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certain there is a better way to do this that doesn't involve listing each module manually, but I figure we can handle that later.

djaglowski and others added 13 commits September 8, 2020 10:09
* Completed test coverage for entry and agent packages

* Made a database package and improved tests

* Improved pipeline test coverage

* Fixed open database in offsets

* Moved operator.Duration to helper.Duration

* Increased test coverage for the plugin package

* Fixed graph command

* Improved JSON test coverage

* Improved regex parser test coverage

* Added tests to persister

* Improved operator package test coverage

* Improved drop_output test coverage

* Improved noop operator test coverage
@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.9827871 +0.051719546 124.77465 -2.4401932
1 5000 6.22425 -1.172461 137.79715 +1.208252
1 10000 13.379588 -3.034505 143.349 -3.7417908
1 50000 67.49333 -11.45668 232.14561 -14.072861
1 100000 122.53782 -26.35453 394.29984 -22.594025
10 100 2.2241645 -0.5862305 131.00876 +0.2172699
10 500 7.465629 -1.2243352 138.40019 +1.3246307
10 1000 14.500357 -2.223774 143.73962 -3.0561676
10 5000 69.19475 -12.844475 215.08473 -11.018173
10 10000 131.48596 -25.274658 363.78204 -13.806732

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6379627 -0.2931049 126.67174 -0.5431061
1 1000 1.8448793 -0.08618832 126.63941 -0.5754318
1 5000 5.8449183 -1.5517926 132.46417 -4.1247253
1 5000 5.96576 -1.4309506 132.64938 -3.9395142
1 10000 12.465878 -3.9482155 143.41446 -3.6763306
1 10000 12.258793 -4.1553 141.70352 -5.387268
1 50000 57.742924 -21.207088 176.65706 -69.56142
1 50000 58.364563 -20.58545 173.75957 -72.45891
1 100000 110.69334 -38.199013 223.38133 -193.51253
1 100000 113.48622 -35.406128 228.90234 -187.99152
10 100 2.362168 -0.44822693 132.0582 +1.2667084
10 100 2.3795123 -0.4308827 129.75067 -1.0408173
10 500 6.741489 -1.9484754 136.51144 -0.56411743
10 500 6.879599 -1.8103652 139.06317 +1.9876099
10 1000 13.535056 -3.1890745 144.40544 -2.3903503
10 1000 14.345145 -2.3789854 144.04135 -2.7544403
10 5000 63.311626 -18.727596 184.14252 -41.96039
10 5000 63.48426 -18.554962 178.34537 -47.757538
10 10000 121.566216 -35.194405 222.94113 -154.64764
10 10000 121.978935 -34.781685 225.87553 -151.71324

@camdencheek camdencheek marked this pull request as ready for review September 11, 2020 17:58
@camdencheek camdencheek merged commit c33b375 into master Sep 11, 2020
@camdencheek camdencheek deleted the submodules branch September 11, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants