Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default output #101

Merged
merged 9 commits into from
Aug 25, 2020
Merged

Default output #101

merged 9 commits into from
Aug 25, 2020

Conversation

djaglowski
Copy link
Member

Description of Changes

Add builder for log agent
Allow a default output operator to be specified

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@observIQ observIQ deleted a comment from codecov bot Aug 24, 2020
@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 3.7587373 +0.3621297 33.0132 +0.94140625
1 5000 9.603733 +0.8449755 44.589306 +2.4955559
1 10000 16.621004 +0.65511036 56.66029 -0.30347824
1 50000 73.31811 +0.6955795 236.10762 +19.121628
1 100000 147.79195 +2.9767761 312.20462 +16.868683
10 100 5.482881 +0.3104 33.18669 +2.7417831
10 500 11.84503 -0.10352898 44.772224 +3.2836723
10 1000 19.31076 -0.2067604 56.3913 -2.6717377
10 5000 80.13955 -0.34295654 199.18736 +18.056976
10 10000 155.36093 -8.653336 312.8843 -10.025848

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.04%.
The diff coverage is 88.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   73.14%   73.17%   +0.04%     
==========================================
  Files          71       71              
  Lines        4277     4294      +17     
==========================================
+ Hits         3128     3142      +14     
- Misses        873      876       +3     
  Partials      276      276              
Impacted Files Coverage Δ
agent/agent.go 77.19% <84.21%> (-0.58%) ⬇️
commands/graph.go 55.26% <100.00%> (ø)
commands/root.go 42.59% <100.00%> (+1.64%) ⬆️
pipeline/config.go 96.27% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445b939...c8bf287. Read the comment docs.

@djaglowski djaglowski marked this pull request as ready for review August 25, 2020 12:49
@djaglowski djaglowski requested a review from camdencheek August 25, 2020 12:49
pipeline/config.go Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 3.8621438 +0.46553612 34.054688 +1.9828949
1 5000 9.862307 +1.103549 45.485588 +3.391838
1 10000 17.2591 +1.2932062 55.74569 -1.2180786
1 50000 71.39387 -1.2286606 203.22723 -13.758759
1 100000 146.63628 +1.821106 306.61798 +11.282043
10 100 5.3105297 +0.13804865 33.90948 +3.464573
10 500 12.052149 +0.10359001 43.975216 +2.4866638
10 1000 19.742037 +0.22451591 57.012794 -2.0502434
10 5000 79.226524 -1.2559814 195.32773 +14.197342
10 10000 150.76433 -13.249939 320.84644 -2.0637207

@camdencheek camdencheek self-requested a review August 25, 2020 15:46
@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 3.7931504 +0.3965428 33.724945 +1.6531525
1 5000 10.448495 +1.6897373 45.952854 +3.8591042
1 10000 16.06933 +0.10343647 55.084995 -1.8787727
1 50000 73.384605 +0.76207733 218.27667 +1.2906799
1 100000 149.2215 +4.4063263 312.9197 +17.58377
10 100 4.982888 -0.18959284 33.18346 +2.738552
10 500 13.931348 +1.982789 44.773167 +3.2846146
10 1000 19.604002 +0.086481094 55.044853 -4.0181847
10 5000 82.69211 +2.2096024 196.58783 +15.457443
10 10000 152.93501 -11.079254 329.11664 +6.206482

@djaglowski djaglowski merged commit 57466e2 into master Aug 25, 2020
@djaglowski djaglowski deleted the default-output branch August 25, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants