Add env support to expressions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
force-pushed
the
env-in-exprs
branch
2 times, most recently
from
e9e9148 to
deedf3c
Compare
Previously, fields could only select values located on the entry's record. However, it's often necessary to filter or parse values that would more naturally exist on fields like labels. This commit refactors fields into an interface which is fulfilled by both the `RecordField` and the `LabelField` objects. `RecordField` is essentially what was previously called `Field`. Notably, this change makes the zero-value of `Field` invalid, since it will contain a `nil` pointer.
To provide support for using environment variables for labeling,
tagging, and routing entries, this commit adds the `env()` function
to expressions.
An example expression: `env("FOO")`.
In addition, this commit fixes an issue with the algorithm for parsing
expressions from `ExprString`s where there are paranthesis nested inside
the expression. This issue was made clear by trying to use the `env()`
function inside an `ExprString`.
This commit also adds the `GetExprEnv` and `PutExprEnv` functions which
provide a way to re-use allocated environment maps. This keeps us from
having to allocate a map for every entry that is rendered as an
expression, which should help improve performance of plugins that
make heavy use of expressions.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 75.82% 75.94% +0.12%
==========================================
Files 58 60 +2
Lines 3478 3566 +88
==========================================
+ Hits 2637 2708 +71
- Misses 628 637 +9
- Partials 213 221 +8
Continue to review full report at Codecov.
|
jmwilliams89
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Depends on #9
Add env() support to expressions
To provide support for using environment variables for labeling,
tagging, and routing entries, this commit adds the
env()functionto expressions.
An example expression:
env("FOO").In addition, this commit fixes an issue with the algorithm for parsing
expressions from
ExprStrings where there are paranthesis nested insidethe expression. This issue was made clear by trying to use the
env()function inside an
ExprString.This commit also adds the
GetExprEnvandPutExprEnvfunctions whichprovide a way to re-use allocated environment maps. This keeps us from
having to allocate a map for every entry that is rendered as an
expression, which should help improve performance of plugins that
make heavy use of expressions.
Also adds another checkbox to PR templates for adding a changelog entry
Please check that the PR fulfills these requirements