Added hadoop #37
Merged
Added hadoop #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
reviewed
Aug 12, 2020
plugins/hadoop.yaml
Outdated
| default: true | ||
| datanode_general_log_path: | ||
| label: DataNode General Log Path | ||
| description: The absolute path to the data node general logs. Simple globbing can be used to collect multiple log files |
There was a problem hiding this comment.
Are we adding the Simple globbing note to all our descriptions? Seems like there's been some inconsistency here
There was a problem hiding this comment.
No. Nice catch. This was how we were doing all of our file path descriptions before in the log bundles. I manually went through and removed these, because I thought it was unnecessary and overly verbose. I just happened to miss this one after generating it.
camdencheek
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.