Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service name and pod name parsing #218

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Fix service name and pod name parsing #218

merged 4 commits into from
Feb 4, 2021

Conversation

jsirianni
Copy link
Member

Updated regex to fix

  • service name k8s_api should be api (removed the k8s_ prefix, it is not part of the actual service name)
  • update pod parsing to allow fully qualified hostnames (periods) to be included

@jsirianni jsirianni requested a review from ericwholt February 4, 2021 15:28
ericwholt
ericwholt approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@ericwholt ericwholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to bump version. Alsu add change log update.

@jsirianni jsirianni merged commit f6eeed2 into master Feb 4, 2021
@jsirianni jsirianni deleted the openshift-regex_parser-pod-name branch February 4, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwholt ericwholt ericwholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirianni @ericwholt