Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added memcached #20

Merged
merged 2 commits into from
Aug 17, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions plugins/memcached.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Plugin Info
version: 0.0.1
title: Memcached
description: Log parser for Memcached
parameters:
file_path:
Copy link
Contributor

@ericwholt ericwholt Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should plugins that have a single file input be log_path to match format of other plugins that have multiple log paths? They use something like general_log_path for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parameter names were pulled directly from the log bundles when I generated them. I know Zack put a lot of effort into standardizing the names across bundles, so I'm guessing there's probably a good reason we did file_path over log_path. My guess is that file_path was used when there is typically one file to point at, whereas log_path was used when you can't point at a directory or glob pattern.

label: Memcached Logs Path
description: The absolute path to the Memcached logs
type: string
default: "/var/log/memcached.log*"
start_at:
label: Start At
description: Start reading file from 'beginning' or 'end'
type: enum
valid_values:
- beginning
- end
default: end

# Set Defaults
{{$file_path := default "/var/log/memcached.log*" .file_path}}
{{$start_at := default "end" .start_at}}

# Pipeline Template
pipeline:
- id: memcached_input
type: file_input
include:
- {{ $file_path }}
start_at: {{ $start_at }}
labels:
log_type: memcached
output: {{.output}}