added memcached #20
Merged
added memcached #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
reviewed
Aug 12, 2020
ericwholt
reviewed
Aug 13, 2020
| title: Memcached | ||
| description: Log parser for Memcached | ||
| parameters: | ||
| file_path: |
There was a problem hiding this comment.
Should plugins that have a single file input be log_path to match format of other plugins that have multiple log paths? They use something like general_log_path for example?
There was a problem hiding this comment.
These parameter names were pulled directly from the log bundles when I generated them. I know Zack put a lot of effort into standardizing the names across bundles, so I'm guessing there's probably a good reason we did file_path over log_path. My guess is that file_path was used when there is typically one file to point at, whereas log_path was used when you can't point at a directory or glob pattern.
ericwholt
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.