fix(test): Fixed config tests for varnish to work on any OS #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corbin Phelps <[email protected]>
cpheps
force-pushed
the
fix-varnish-tests
branch
from
17d2d7f to
73720d1
Compare
dehaansa
approved these changes
Mar 22, 2022
Signed-off-by: Corbin Phelps <[email protected]>
BinaryFissionGames
approved these changes
Mar 22, 2022
JonathanWamsley
approved these changes
Mar 22, 2022
dehaansa
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
The previous varnish tests depended on an os specific string for path errors. Due to using multierror it makes error checking a bit difficult using
errors.Isso I removed the compound test and update tests to check errors for string contains of base error.Checklist