Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Run CI tests on all submodules #309

Merged
merged 2 commits into from
Mar 22, 2022
Merged

fix(ci): Run CI tests on all submodules #309

merged 2 commits into from
Mar 22, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Mar 22, 2022

Proposed Change

Temporary fix to ensure tests are being run on all submodules as the previous script to find submodules would not work on windows.

Checklist
  • Changes are tested
  • CI has passed

@cpheps cpheps requested a review from a team as a code owner March 22, 2022 16:45
@cpheps cpheps requested a review from armstrmi March 22, 2022 16:45
@cpheps cpheps added the do not merge Don't merge this PR yet label Mar 22, 2022
@cpheps cpheps force-pushed the fix-ci-test-flow branch from 277a757 to 69d1a53 Compare March 22, 2022 17:07
@cpheps cpheps removed the do not merge Don't merge this PR yet label Mar 22, 2022
@cpheps cpheps force-pushed the fix-ci-test-flow branch from 69d1a53 to 349b502 Compare March 22, 2022 17:43
@BinaryFissionGames
Copy link
Contributor

Looks like varnish tests fail on windows since the error messages returned aren't the exact same as on linux:

--- FAIL: TestValidate (0.00s)
    --- FAIL: TestValidate/missing_exec_dir (0.00s)
        config_test.go:70: 
            	Error Trace:	config_test.go:70
            	Error:      	Error message not equal:
            	            	expected: "\"exec_dir\" does not exists \"stat missing/exec: no such file or directory\""
            	            	actual  : "\"exec_dir\" does not exists \"CreateFile missing/exec: The system cannot find the path specified.\""
            	Test:       	TestValidate/missing_exec_dir
    --- FAIL: TestValidate/missing_working_dir (0.00s)
        config_test.go:70: 
            	Error Trace:	config_test.go:70
            	Error:      	Error message not equal:
            	            	expected: "\"working_dir\" does not exists \"stat missing/working: no such file or directory\""
            	            	actual  : "\"working_dir\" does not exists \"CreateFile missing/working: The system cannot find the path specified.\""
            	Test:       	TestValidate/missing_working_dir
    --- FAIL: TestValidate/missing_exec_and_working_dir (0.00s)
        config_test.go:70: 
            	Error Trace:	config_test.go:70
            	Error:      	Error message not equal:
            	            	expected: "\"working_dir\" does not exists \"stat missing/working: no such file or directory\"; \"exec_dir\" does not exists \"stat missing/exec: no such file or directory\""
            	            	actual  : "\"working_dir\" does not exists \"CreateFile missing/working: The system cannot find the path specified.\"; \"exec_dir\" does not exists \"CreateFile missing/exec: The system cannot find the path specified.\""
            	Test:       	TestValidate/missing_exec_and_working_dir
FAIL
FAIL	github.com/observiq/observiq-otel-collector/receiver/varnishreceiver	0.0[60](https://github.com/observIQ/observiq-otel-collector/runs/5648134972?check_suite_focus=true#step:7:60)s

but that proves that the tests DO run on windows, at least.

@cpheps cpheps force-pushed the fix-ci-test-flow branch from 349b502 to e264fd4 Compare March 22, 2022 19:00
Corbin Phelps added 2 commits March 22, 2022 15:58
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
@cpheps cpheps force-pushed the fix-ci-test-flow branch from e264fd4 to 3c7faf3 Compare March 22, 2022 19:58
@cpheps cpheps merged commit 0757e10 into main Mar 22, 2022
@cpheps cpheps deleted the fix-ci-test-flow branch March 22, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants