fix: Fix malformed gosec yaml #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
fix-go-sec
branch
from
2b73dd0 to
2e88c37
Compare
cpheps
approved these changes
Mar 22, 2022
jmwilliams89
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Both "uses" and "working-directory" cannot be simultaneously be specified, so the action was not valid and does not run.
Unfortunately, gosec doesn't provide a way to tell it which module you want to use, it just assumes the module root is the CWD (which cannot be changed for "uses" job steps). If we want to get it to work, we need to use the make target instead of the action.
Checklist