Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otel receiver): Rename varnish attribute #305

Merged
merged 5 commits into from
Mar 22, 2022
Merged

fix(otel receiver): Rename varnish attribute #305

merged 5 commits into from
Mar 22, 2022

Conversation

JonathanWamsley
Copy link
Contributor

@JonathanWamsley JonathanWamsley commented Mar 21, 2022 •
edited
Loading

Proposed Change

Rename attribute from client_requests to type to reflect scope doc changes.

expected.json can be deleted since it is no longer used in testing.

Checklist
  • Changes are tested
  • CI has passed

@JonathanWamsley JonathanWamsley requested a review from a team as a code owner March 21, 2022 20:32
@JonathanWamsley JonathanWamsley merged commit b435e53 into main Mar 22, 2022
@JonathanWamsley JonathanWamsley deleted the varnish-attribute-update branch March 22, 2022 13:22
@JonathanWamsley JonathanWamsley mentioned this pull request Mar 22, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@dehaansa dehaansa dehaansa approved these changes

@armstrmi armstrmi Awaiting requested review from armstrmi armstrmi was automatically assigned from observIQ/ot-pipeline-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanWamsley @dehaansa @BinaryFissionGames