Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): Inner modules #293

Merged
merged 5 commits into from
Mar 18, 2022
Merged

feat(modules): Inner modules #293

merged 5 commits into from
Mar 18, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Mar 18, 2022

Proposed Change

  • Broke logsreceiver into it's own module
  • Broke resourceattributetransposerprocessor into it's own module
  • Refactored Make tasks to run on all submodules

Breaking into modules had a few side effects:

  • Had to move operators package uner the logsreceiver module
  • Had to add replace statements for opentelemetry-collector from 0.47.0 -> 0.46.0 as they removed the exporter and receiver helper packages. We'll have to address this when we update to 0.47.0 as a whole.
Checklist
  • Changes are tested
  • CI has passed

@cpheps cpheps requested a review from a team as a code owner March 18, 2022 15:53
@cpheps cpheps requested a review from schmikei March 18, 2022 15:53
Corbin Phelps added 2 commits March 18, 2022 11:55
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also want dependabot to look at the new modules

@BinaryFissionGames
Copy link
Contributor

Also, do make tasks like "check-fmt" run for all submodules?

go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
license.yaml Show resolved Hide resolved
processor/resourceattributetransposerprocessor/go.mod Outdated Show resolved Hide resolved
receiver/logsreceiver/README.md Outdated Show resolved Hide resolved
receiver/logsreceiver/README.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Corbin Phelps <[email protected]>
@cpheps
Copy link
Contributor Author

cpheps commented Mar 18, 2022

@BinaryFissionGames

Also, do make tasks like "check-fmt" run for all submodules?

I double checked those commands and they aren't locked to a module but rather just run recursively from where they are executed.

Signed-off-by: Corbin Phelps <[email protected]>
@cpheps
Copy link
Contributor Author

cpheps commented Mar 18, 2022

We probably also want dependabot to look at the new modules
Done!

@cpheps cpheps merged commit 53871e3 into main Mar 18, 2022
@cpheps cpheps deleted the inner-modules branch March 18, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants