Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix MSI build #280

Merged
merged 3 commits into from
Mar 16, 2022
Merged

fix: Fix MSI build #280

merged 3 commits into from
Mar 16, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented Mar 15, 2022 •
edited
Loading

Proposed Change

  • Fix goreleaser build failing due to ssh git cloning
  • Avoid downloading dependencies twice.
Checklist
  • Changes are tested
  • CI has passed

@BinaryFissionGames BinaryFissionGames force-pushed the windows-goreleaser-build-fix branch from 5e4c7b0 to 51f47f2 Compare March 15, 2022 18:46
@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review March 15, 2022 19:13
@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner March 15, 2022 19:13
cpheps
cpheps approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I missed some updates in the windows release action. Thanks for fixing them up.

@BinaryFissionGames BinaryFissionGames merged commit 0f8de96 into main Mar 16, 2022
@BinaryFissionGames BinaryFissionGames deleted the windows-goreleaser-build-fix branch March 16, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpheps cpheps cpheps approved these changes

@dehaansa dehaansa dehaansa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BinaryFissionGames @dehaansa @cpheps