Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: goreleaser needs GITHUB_TOKEN to build #265

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix: goreleaser needs GITHUB_TOKEN to build #265

merged 1 commit into from
Mar 7, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Proposed Change

  • Use the action for building in the build-msi job, didn't realize that we can do things other than release with it, should be more robust.
  • Add GITHUB_TOKEN to dockerfile so that goreleaser can build properly
    • I tested this locally and docker CAN build this when supplied the token
Checklist
  • Changes are tested
  • CI has passed

@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner March 7, 2022 17:19
@BinaryFissionGames BinaryFissionGames merged commit 616ef19 into main Mar 7, 2022
@BinaryFissionGames BinaryFissionGames deleted the release-pass-github-token branch March 7, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmikei schmikei schmikei approved these changes

@cpheps cpheps cpheps approved these changes

@JonathanWamsley JonathanWamsley Awaiting requested review from JonathanWamsley JonathanWamsley was automatically assigned from observIQ/ot-pipeline-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BinaryFissionGames @cpheps @schmikei