Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Document installing the collector on Windows #261

Merged
merged 7 commits into from
Mar 10, 2022
Merged

feat: Document installing the collector on Windows #261

merged 7 commits into from
Mar 10, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Proposed Change

  • Add documentation for installing/uninstalling the collector on Windows.
Checklist
  • Changes are tested
  • CI has passed

@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner March 4, 2022 17:45
schmikei
schmikei approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is the plan to eventually link this to some general install doc?

@BinaryFissionGames
Copy link
Contributor Author

@schmikei I just added a link in the main README, so there's some discoverability there now.

In terms of more general installation docs other than just a jumping off point to specific OS installation docs, not sure what else there is that is more general about the installation process.

@schmikei
Copy link
Contributor

schmikei commented Mar 7, 2022

@schmikei I just added a link in the main README, so there's some discoverability there now.

In terms of more general installation docs other than just a jumping off point to specific OS installation docs, not sure what else there is that is more general about the installation process.

Yep sounds good 👍 was just curious as for getting people to see this doc was what I was looking for and your most recent change addresses that!

cpheps
cpheps approved these changes Mar 8, 2022
View reviewed changes
docs/installation-windows.md Outdated Show resolved Hide resolved
@BinaryFissionGames BinaryFissionGames merged commit d7b0ef2 into main Mar 10, 2022
@BinaryFissionGames BinaryFissionGames deleted the windows-docs branch March 10, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmikei schmikei schmikei approved these changes

@cpheps cpheps cpheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BinaryFissionGames @schmikei @cpheps