-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize chronicle exporter by http and grpc #2044
Open
djaglowski
wants to merge
7
commits into
release/v1.68.0
Choose a base branch
from
split-http-grpc
base: release/v1.68.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
split-http-grpc
branch
from
December 11, 2024 18:57
8176098
to
c6e9f62
Compare
mrsillydog
reviewed
Dec 11, 2024
djaglowski
force-pushed
the
split-http-grpc
branch
from
December 12, 2024 16:01
7e1001a
to
77e1571
Compare
This was referenced Dec 12, 2024
djaglowski
force-pushed
the
split-http-grpc
branch
from
December 12, 2024 19:41
77e1571
to
5c7ebbb
Compare
djaglowski
force-pushed
the
split-http-grpc
branch
from
December 16, 2024 19:21
5c7ebbb
to
3fcfd6b
Compare
dpaasman00
force-pushed
the
release/v1.67.0
branch
from
December 16, 2024 20:06
104caa3
to
40fbb1f
Compare
djaglowski
force-pushed
the
split-http-grpc
branch
from
December 16, 2024 20:53
3fcfd6b
to
160c0d7
Compare
djaglowski
force-pushed
the
split-http-grpc
branch
from
December 17, 2024 14:14
160c0d7
to
1b00c79
Compare
Several smaller PRs have been peeled off and merged. What's left is a large diff but is almost entirely just moving the marshaler into an internal package and separating the functionality into http and grpc variants. The benefit of doing this is that it is now tested according to its exported surface area only, but without exposing the exported surface area to other packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains many changes so it may be wise to chunk it out into smaller changes. However, I'm opening it as a draft in order to facilitate feedback on the overall direction.
Changes included:
Future work: